generated from john/python-template
Jim LancasterandCopilot App
f15c9834e4
Quality Gate / gate (push) Failing after 47s
The handoff brief was a work order for phases 2-5. That work is done, so the document now describes a future that already happened and would misdirect anyone who found it. The review report itself had the same problem in weaker form: its findings read as open. Adds a status banner marking it closed and retained for reasoning only. The banner also records that two of its recommendations were wrong on contact. The HIGH-03 fix as written would have stripped root-cause data from ExecutionAttempt provenance, and the HIGH-01 fix had to preserve per-page durability the report never mentioned. Leaving that unstated invites someone to 'restore' the report's version later. Co-authored-by: Copilot App <[email protected]>
22 lines
1.0 KiB
Markdown
22 lines
1.0 KiB
Markdown
# Review Reports
|
|
|
|
Dated architecture and code review reports generated by
|
|
`.github/skills/python-code-reviewer/skill.md`.
|
|
|
|
**These files are not canonical authority.** Everything in `docs/reviews/**` is a
|
|
point-in-time observation, not a contract. Canonical intent lives in `docs/index.md`,
|
|
`docs/architecture.md`, `docs/requirements.md`, `docs/schema.md`,
|
|
`docs/error_handling.md`, and `docs/invariant/**`. When a report and a canonical
|
|
document disagree, the canonical document wins until it is deliberately updated.
|
|
|
|
Naming: `<YYYY-MM-DD>-code-review.md` for review reports, and
|
|
`<YYYY-MM-DD>-remediation-handoff.md` for the implementation plan derived from one.
|
|
|
|
## Current
|
|
|
|
- [`2026-08-23-code-review.md`](./2026-08-23-code-review.md) — full review. 0 critical,
|
|
4 high, 5 medium, 11 low. **All findings remediated.** Retained as a record of the
|
|
reasoning, not as a list of open work. Note that a few of its recommendations were
|
|
wrong on contact and were corrected during implementation; the code and the guard
|
|
tests are authoritative over the report text.
|