WIP simplifying load/startup

src/personal_mcp/registry/ingest/skill.py

@@ -1,19 +1,19 @@
+import re
 from collections.abc import Iterable
 from collections.abc import Mapping
 from dataclasses import dataclass
-from fnmatch import fnmatch
 from importlib.resources.abc import Traversable
 from itertools import groupby
 from itertools import starmap
 from pathlib import PurePosixPath
 from typing import Self
 
+from personal_mcp.registry.models.common import SKILL_ID_RE
+from personal_mcp.registry.models.common import DocsPath
 from personal_mcp.registry.models.common import ReferenceEntry
 from personal_mcp.registry.models.skill import SkillFrontmatter
 from personal_mcp.registry.models.skill import StoredSkill
 from personal_mcp.registry.models.skill import StoredSkillReference
-from personal_mcp.skills.document_loader import _reference_id_from_filename
-from personal_mcp.skills.document_loader import _title_from_reference_filename
 
 from .document import MarkdownDocument
 
@@ -39,8 +39,9 @@ class SkillFilesBundle:
     @classmethod
     def from_paths(cls, slug: str, paths: set[MarkdownDocument]) -> Self:
         skill = next(iter(p for p in paths if p.relpath.name == "SKILL.md"))
-        sorted_paths = tuple(sorted(paths, key=lambda p: p.relpath.as_posix()))
-        references = tuple(p for p in sorted_paths if fnmatch(p.relpath.as_posix(), f"skills/{slug}/references/*.md"))
+        sorted_paths = tuple(sorted(paths, key=lambda p: p.relpath))
+        references_dir = PurePosixPath("skills", slug, "references")
+        references = tuple(p for p in sorted_paths if p.relpath.parent == references_dir)
         other = tuple(p for p in sorted_paths if p not in references and p != skill)
         return cls(
             slug=slug,
@@ -60,6 +61,23 @@ def group_skill_paths(docs: Iterable[MarkdownDocument]) -> dict[str, set[Markdow
     return {k: set(g) for k, g in grouped if k}
 
 
+def _title_from_reference_filename(filename: str) -> str:
+    stem = PurePosixPath(filename).stem
+    normalized = stem.replace("-", " ").replace("_", " ").split()
+    if not normalized:
+        return stem
+    return " ".join(token.capitalize() for token in normalized)
+
+
+def _reference_id_from_filename(filename: str) -> str | None:
+    stem = PurePosixPath(filename).stem.strip().lower().replace("_", "-")
+    normalized = re.sub(r"[^a-z0-9-]+", "-", stem)
+    normalized = re.sub(r"-+", "-", normalized).strip("-")
+    if not normalized or not SKILL_ID_RE.fullmatch(normalized):
+        return None
+    return normalized
+
+
 def _discover_reference_entries(bundle: SkillFilesBundle) -> dict[str, ReferenceEntry]:
     discovered: dict[str, ReferenceEntry] = {}
     for reference_doc in bundle.references:
@@ -67,7 +85,7 @@ def _discover_reference_entries(bundle: SkillFilesBundle) -> dict[str, Reference
         if ref_id is None:
             continue
         discovered[ref_id] = ReferenceEntry(
-            path=PurePosixPath("references").joinpath(reference_doc.relpath.name).as_posix(),
+            path=PurePosixPath("references", reference_doc.relpath.name),
             title=_title_from_reference_filename(reference_doc.relpath.name),
         )
     return discovered
@@ -76,7 +94,7 @@ def _discover_reference_entries(bundle: SkillFilesBundle) -> dict[str, Reference
 def build_stored_skill(
     *,
     bundle: SkillFilesBundle,
-    docs_by_relpath: Mapping[PurePosixPath, MarkdownDocument],
+    docs_by_relpath: Mapping[DocsPath, MarkdownDocument],
 ) -> StoredSkill:
     frontmatter = SkillFrontmatter.from_raw_yaml(bundle.skill.frontmatter)
     metadata = frontmatter.x_personal_mcp
@@ -85,7 +103,7 @@ def build_stored_skill(
 
     references: dict[str, StoredSkillReference] = {}
     for ref_id, entry in sorted(merged_entries.items()):
-        ref_relpath = PurePosixPath("skills").joinpath(bundle.slug).joinpath(entry.path)
+        ref_relpath = PurePosixPath("skills", bundle.slug, entry.path)
         if ref_relpath not in docs_by_relpath:
             raise KeyError(f"reference document not found for '{metadata.id}:{ref_id}' at {ref_relpath.as_posix()}")
         ref_doc = docs_by_relpath[ref_relpath]