4 Commits

Include renames

Author	SHA1	Message	Date
Jim LancasterandCopilot App	c52d41ec33	test: extend orphan sweep to public class methods ... Co-authored-by: Copilot App <[email protected]>	2026-08-23 18:52:06 -05:00
Jim LancasterandCopilot App	6c3eac0a44	test: prune low-signal assertions and tighten guards ... Co-authored-by: Copilot App <[email protected]>	2026-08-23 18:48:16 -05:00
Jim LancasterandCopilot App	2a56365847	style: apply ruff formatting sweep ... Co-authored-by: Copilot App <[email protected]>	2026-08-23 18:13:38 -05:00
Jim LancasterandCopilot App	c6ed3126e0	Enforce the four unenforced reviewer checks with guard tests ... The reviewer skill recorded four deterministic checks as unenforced or partial. Add tests so they fail the build instead of relying on a reviewer noticing. tests/test_model_contract_guards.py: - Status vocabulary: flags string literals compared against or assigned to status/purpose attributes, plus a narrower sweep that requires every status-valued literal in the package to be a known non-status use. - Relationship loading: every Relationship must declare lazy='raise' except documented exceptions, and the exception set must match the Relationship Loading Contract in docs/schema.md. - Schema fidelity: the Field-Accurate Table Contracts tables must match db/models.py on table coverage, field names, and declaration order, and the Authoritative Enumerations section must match the enum members. tests/test_orphan_sweep.py: - Locks the set of unreferenced public definitions. Route handlers registered by decorator are exempt, string entrypoint references count, and tests/ and tools/ count as consumers. KNOWN_ORPHANS records the four current orphans with rationale; a new one fails the build. Each guard was mutation-tested: reverting the fix below, dropping a documented field, widening a lazy strategy, and adding a stranded function each fail their respective test. Also fix the one violation the status guard found: sources_page.py compared attempt.status.value to the literal 'transcribed' instead of JobSourceStatus.TRANSCRIBED, which would survive an enum rename. Co-authored-by: Copilot App <[email protected]>	2026-08-23 16:35:48 -05:00