8 Commits

Include renames

Author	SHA1	Message	Date
Jim Lancaster	fc4288ff88	Update instructions - part 2	2026-09-02 14:31:40 -05:00
Jim LancasterandCopilot App	de18c2e9da	Fix workflow commit atomicity, error path leak, and UI error boundary ... Phase 1 of docs/reviews/2026-08-23-code-review.md. HIGH-01: process_queued_job committed page evidence and the terminal job status in separate transactions, so a crash between them left a transcript persisted against a job stuck in PROCESSING that the worker never reclaims. The final page's write is now deferred into _finalize_batch_outcome so it shares the terminal transaction. Intermediate pages remain individually durable, and the terminal commit is shielded against cancellation the same way per-page writes already were. HIGH-04: added tests/integration/test_pipeline_atomicity.py covering both Transaction B and Transaction C. Confirmed failing against the previous implementation before the fix. HIGH-03: classify_unexpected_error interpolated the raw exception into AppError.message, which the UI renders and the API serializes, leaking the database path from OperationalError. message is now generic. Because message also feeds format_error_detail, which writes evidence records, the root cause is preserved on a new internal-only AppError.detail field rather than discarded. HIGH-02: replaced 8 hand-rolled ui.notify error calls in home_page and people_page with error_presenter.show_error, restoring the correlation error_id, canonical category, and suggestion. Added an AST guard to test_ui_boundaries.py so pages cannot hand-roll error notifications again. Docs updated per documentation-sync: the message/detail split in docs/error_handling.md and the multi-page atomicity rule in services.instructions.md. Verification: ruff clean, 381 tests passing, ty unchanged at 10 known SQLAlchemy descriptor false positives. Co-authored-by: Copilot App <[email protected]>	2026-08-23 18:02:04 -05:00
Jim Lancaster	ed6998d8da	V5.1 Update tests and documentation	2026-08-23 16:01:53 -05:00
Jim Lancaster	bf2f3ac09c	Remove references to "v4" throughout the code and documentation	2026-08-20 16:35:20 -05:00
Jim Lancaster	3eefc36239	Update V1 & V2 core documents and reorganize docs folder	2026-07-31 10:04:07 -05:00
Jim Lancaster	a3b3bab571	V1 mostly complete except for some testing. Linting in the last step changed nearly every file which is why this commit is so larger.	2026-07-29 17:27:21 -05:00
Jim Lancaster	ec61013b47	Used co-pilot for complete review of all documentation, including extensive revision of v1.md	2026-07-02 12:37:32 -05:00
Jim Lancaster	0cc6b0e1eb	error_handling.md added	2026-06-25 12:10:49 -05:00