9 Commits

Include renames

Author	SHA1	Message	Date
Jim LancasterandCopilot App	c6ed3126e0	Enforce the four unenforced reviewer checks with guard tests ... The reviewer skill recorded four deterministic checks as unenforced or partial. Add tests so they fail the build instead of relying on a reviewer noticing. tests/test_model_contract_guards.py: - Status vocabulary: flags string literals compared against or assigned to status/purpose attributes, plus a narrower sweep that requires every status-valued literal in the package to be a known non-status use. - Relationship loading: every Relationship must declare lazy='raise' except documented exceptions, and the exception set must match the Relationship Loading Contract in docs/schema.md. - Schema fidelity: the Field-Accurate Table Contracts tables must match db/models.py on table coverage, field names, and declaration order, and the Authoritative Enumerations section must match the enum members. tests/test_orphan_sweep.py: - Locks the set of unreferenced public definitions. Route handlers registered by decorator are exempt, string entrypoint references count, and tests/ and tools/ count as consumers. KNOWN_ORPHANS records the four current orphans with rationale; a new one fails the build. Each guard was mutation-tested: reverting the fix below, dropping a documented field, widening a lazy strategy, and adding a stranded function each fail their respective test. Also fix the one violation the status guard found: sources_page.py compared attempt.status.value to the literal 'transcribed' instead of JobSourceStatus.TRANSCRIBED, which would survive an enum rename. Co-authored-by: Copilot App <[email protected]>	2026-08-23 16:35:48 -05:00
Jim LancasterandCopilot App	5566f48fc0	Align python-code-reviewer skill with repo ground truth ... Update the reviewer skill so its procedure matches how this repo actually works: - Route review reports to docs/reviews/ and mark them non-canonical, resolving the conflict where reports landed in the same docs/ tree they resolve findings against. - Pin verification commands to uv (uv run ruff check / ty check / pytest -m 'not external'). - Record the pytest contract: strict markers, strict asyncio mode, and the never-awaited-coroutine warning promoted to an error. - Convert the deterministic checks to a table with an Enforced by column; three checks are unenforced and one only partial, which are now findings by construction. - Add a consequence-based severity rubric and a Direction column for bidirectional drift. - Escalate test-suite concerns to test-effectiveness-auditor. Also fix tests/test_db.py, which was missing 'from sqlalchemy import text' while using it in 14 places. Three tests were failing with NameError. Wrapped the pre-existing long lines in the same file so it lints clean. Document the deliberate nicegui==3.13.0 pin in pyproject.toml, a new runbook dependency upgrade policy, and the reviewer skill, so the pin is not flagged as a defect or widened as incidental cleanup. Co-authored-by: Copilot App <[email protected]>	2026-08-23 16:27:44 -05:00
Jim Lancaster	bf2f3ac09c	Remove references to "v4" throughout the code and documentation	2026-08-20 16:35:20 -05:00
Jim Lancaster	8b08478c9d	claude-sonnet-5 review: Phase 4 (by gpt-5.3-codex)	2026-08-20 16:04:37 -05:00
Jim Lancaster	7c4300f9c2	gpt-5.3 codex review: Phase 7 and the addition of the new test-effectiveness-auditor skill.	2026-08-20 11:50:10 -05:00
Jim Lancaster	30fcef3892	gpt-5.3-codex review Phase 3	2026-08-19 20:50:21 -05:00
Jim Lancaster	b6a5a89a84	gpt-5.3-codex review phase 2 - update instructions & skills	2026-08-19 18:22:06 -05:00
Jim Lancaster	5404224079	gpt-5.3-codex review phase 1 - Flatten the documentation	2026-08-19 14:54:24 -05:00
zoltan57	1ee9ebbffc	Created new code-review agent and ran it using Claude.	2026-08-17 14:39:52 -05:00