6 Commits

Include renames

Author	SHA1	Message	Date
Jim Lancaster	02dca888d2	Code-review complete	2026-09-02 15:47:53 -05:00
Jim LancasterandCopilot App	f15c9834e4	Remove completed remediation handoff and mark the review closed ... The handoff brief was a work order for phases 2-5. That work is done, so the document now describes a future that already happened and would misdirect anyone who found it. The review report itself had the same problem in weaker form: its findings read as open. Adds a status banner marking it closed and retained for reasoning only. The banner also records that two of its recommendations were wrong on contact. The HIGH-03 fix as written would have stripped root-cause data from ExecutionAttempt provenance, and the HIGH-01 fix had to preserve per-page durability the report never mentioned. Leaving that unstated invites someone to 'restore' the report's version later. Co-authored-by: Copilot App <[email protected]>	2026-08-23 19:25:39 -05:00
Jim LancasterandCopilot App	2a56365847	style: apply ruff formatting sweep ... Co-authored-by: Copilot App <[email protected]>	2026-08-23 18:13:38 -05:00
Jim LancasterandCopilot App	4aaa9bd581	Add remediation handoff brief for review phases 2-5 ... Records the implementation plan derived from the 2026-08-23 review: per-task acceptance criteria, the verification baseline, and environment constraints. Lives in docs/reviews/ so it is discoverable from the repo rather than from session state, and is indexed from docs/reviews/README.md. Non-canonical, like everything under docs/reviews/**. Co-authored-by: Copilot App <[email protected]>	2026-08-23 18:04:55 -05:00
Jim LancasterandCopilot App	8d3c60fce1	Add 2026-08-23 architecture and code review report ... Full review per .github/skills/python-code-reviewer/skill.md, with escalations to the evidence-provenance-auditor and test-effectiveness-auditor skills. Verification: ruff clean, 377 tests passing, 10 advisory ty diagnostics. Outcome: 0 critical, 4 high, 5 medium, 11 low. Report only; no source changes. Co-authored-by: Copilot App <[email protected]>	2026-08-23 17:13:10 -05:00
Jim LancasterandCopilot App	5566f48fc0	Align python-code-reviewer skill with repo ground truth ... Update the reviewer skill so its procedure matches how this repo actually works: - Route review reports to docs/reviews/ and mark them non-canonical, resolving the conflict where reports landed in the same docs/ tree they resolve findings against. - Pin verification commands to uv (uv run ruff check / ty check / pytest -m 'not external'). - Record the pytest contract: strict markers, strict asyncio mode, and the never-awaited-coroutine warning promoted to an error. - Convert the deterministic checks to a table with an Enforced by column; three checks are unenforced and one only partial, which are now findings by construction. - Add a consequence-based severity rubric and a Direction column for bidirectional drift. - Escalate test-suite concerns to test-effectiveness-auditor. Also fix tests/test_db.py, which was missing 'from sqlalchemy import text' while using it in 14 places. Three tests were failing with NameError. Wrapped the pre-existing long lines in the same file so it lints clean. Document the deliberate nicegui==3.13.0 pin in pyproject.toml, a new runbook dependency upgrade policy, and the reviewer skill, so the pin is not flagged as a defect or widened as incidental cleanup. Co-authored-by: Copilot App <[email protected]>	2026-08-23 16:27:44 -05:00