Implemented v1 step1

tests/test_db.py

@@ -1,7 +1,5 @@
 """Tests for transcription.db — schema bootstrap and session factory."""
 
-from unittest.mock import patch
-
 from sqlalchemy import inspect, text
 from sqlmodel import Session, SQLModel, create_engine
 from sqlmodel.pool import StaticPool
@@ -25,7 +23,9 @@ class TestSchemaBootstrap:
         # Ensure models are imported so metadata is populated
         from transcription.models import Document, Job, Transcript  # noqa: F401
 
-        SQLModel.metadata.create_all(engine)
+        import transcription.db as db_module
+
+        db_module.create_all(engine=engine)
 
         inspector = inspect(engine)
         table_names = set(inspector.get_table_names())
@@ -37,41 +37,60 @@ class TestSchemaBootstrap:
 class TestSessionFactory:
     """Verify get_session yields and cleans up sessions."""
 
-    def test_get_session_yields_session(self, monkeypatch):
+    def test_get_session_yields_session(self):
         """get_session() yields a usable Session object."""
-        monkeypatch.setenv("OPENROUTER_API_KEY", "test-key-for-db")
-        # Clear the lru_cache so Settings is re-created with our env var
-        from transcription.config import get_settings
-        get_settings.cache_clear()
-
         engine = _in_memory_engine()
         SQLModel.metadata.create_all(engine)
 
         import transcription.db as db_module
-        with patch.object(db_module, "engine", engine):
-            with db_module.get_session() as session:
-                assert isinstance(session, Session)
 
-        get_settings.cache_clear()
+        with db_module.get_session(engine=engine) as session:
+            assert isinstance(session, Session)
 
-    def test_session_is_closed_after_generator_exit(self, monkeypatch):
+    def test_session_is_closed_after_generator_exit(self):
         """After the context manager exits, the session is closed."""
-        monkeypatch.setenv("OPENROUTER_API_KEY", "test-key-for-db")
-        from transcription.config import get_settings
-        get_settings.cache_clear()
-
         engine = _in_memory_engine()
         SQLModel.metadata.create_all(engine)
 
         import transcription.db as db_module
-        with patch.object(db_module, "engine", engine):
-            with db_module.get_session() as session:
-                # Session is usable inside the context
-                session.execute(text("SELECT 1"))
-                captured = session
+
+        with db_module.get_session(engine=engine) as session:
+            # Session is usable inside the context
+            session.execute(text("SELECT 1"))
+            captured = session
 
         # After exiting, the session's internal connection is released
         # (no active transaction bound to the session)
         assert captured._transaction is None
 
-        get_settings.cache_clear()
+
+class TestBootstrapPolicy:
+    """Verify schema bootstrap policy defaults and overrides."""
+
+    def test_production_defaults_to_no_bootstrap(self):
+        """Production defaults to explicit non-bootstrap startup behavior."""
+        from transcription.config import Settings
+        from transcription.db import should_bootstrap_schema
+
+        settings = Settings(openrouter_api_key="test-key", environment="production")
+        assert should_bootstrap_schema(settings) is False
+
+    def test_development_defaults_to_bootstrap(self):
+        """Development defaults to schema bootstrap for local workflows."""
+        from transcription.config import Settings
+        from transcription.db import should_bootstrap_schema
+
+        settings = Settings(openrouter_api_key="test-key", environment="development")
+        assert should_bootstrap_schema(settings) is True
+
+    def test_explicit_override_wins(self):
+        """Explicit bootstrap_schema_on_startup overrides environment default."""
+        from transcription.config import Settings
+        from transcription.db import should_bootstrap_schema
+
+        settings = Settings(
+            openrouter_api_key="test-key",
+            environment="production",
+            bootstrap_schema_on_startup=True,
+        )
+        assert should_bootstrap_schema(settings) is True