gpt-5.3 codex review: Phase 4
Quality Gate / gate (push) Failing after 11s

This commit is contained in:
Jim Lancaster
2026-08-19 21:16:36 -05:00
parent 30fcef3892
commit cdd846fe29
16 changed files with 765 additions and 26 deletions
+34
View File
@@ -0,0 +1,34 @@
from pathlib import Path
from transcription.ui.components.media_urls import public_media_path_label
def test_public_media_path_label_maps_managed_absolute_path_to_upload_route(tmp_path):
upload_dir = tmp_path / "uploads"
managed_path = upload_dir / "documents" / "abc" / "page.jpg"
managed_path.parent.mkdir(parents=True, exist_ok=True)
managed_path.write_bytes(b"x")
label = public_media_path_label(str(managed_path), upload_dir=upload_dir)
assert label == "/uploads/documents/abc/page.jpg"
def test_public_media_path_label_hides_unmanaged_absolute_path(tmp_path):
upload_dir = tmp_path / "uploads"
unmanaged_path = tmp_path / "other-root" / "secret" / "page.jpg"
label = public_media_path_label(str(unmanaged_path), upload_dir=upload_dir)
assert label == "page.jpg"
def test_public_media_path_label_preserves_upload_relative_route(tmp_path):
upload_dir = tmp_path / "uploads"
label = public_media_path_label("documents/person-1/photo.png", upload_dir=upload_dir)
assert label == "/uploads/documents/person-1/photo.png"
def test_public_media_path_label_keeps_existing_upload_route(tmp_path):
upload_dir = tmp_path / "uploads"
assert public_media_path_label("/uploads/documents/d1/page.png", upload_dir=upload_dir) == (
"/uploads/documents/d1/page.png"
)