gpt-5.3 codex review: Phase 4
Quality Gate / gate (push) Failing after 11s

This commit is contained in:
Jim Lancaster
2026-08-19 21:16:36 -05:00
parent 30fcef3892
commit cdd846fe29
16 changed files with 765 additions and 26 deletions
@@ -72,3 +72,36 @@ def resolve_media_url(path: str | None, *, upload_dir: Path, base_url: str) -> s
return absolute_upload_url(f"/uploads/{quote(normalized)}", base_url=base_url)
return absolute_upload_url(f"/uploads/{quote(path_obj.name)}", base_url=base_url)
def public_media_path_label(path: str | None, *, upload_dir: Path) -> str:
"""Return a safe, non-local path label for UI metadata display."""
candidate = (path or "").strip()
if not candidate:
return "unknown"
normalized = candidate.replace("\\", "/")
lowered = normalized.casefold()
if normalized.startswith(_UPLOAD_ROUTE_PREFIX):
return normalized
if lowered.startswith("uploads/"):
return f"/{normalized}"
if lowered.startswith("data/"):
relative = normalized.split("/", 1)[1] if "/" in normalized else ""
return f"/uploads/{relative}" if relative else "/uploads"
if lowered.startswith(("documents/", "persons/")):
return f"/uploads/{normalized}"
resolved_upload_dir = upload_dir.resolve()
path_obj = Path(candidate)
if path_obj.is_absolute():
absolute_candidate = path_obj.resolve()
try:
relative = absolute_candidate.relative_to(resolved_upload_dir).as_posix()
return f"/uploads/{relative}"
except ValueError:
# Never expose non-managed absolute filesystem paths.
return path_obj.name or "unknown"
return f"/uploads/{quote(path_obj.name)}"