Updated test suite

tests/test_app.py

@@ -1,5 +1,7 @@
 """Tests for transcription.app."""
 
+from contextlib import asynccontextmanager
+
 import pytest
 from fastapi import FastAPI
 from fastapi.testclient import TestClient
@@ -21,28 +23,43 @@ class TestAppFactory:
 class TestAppLifespan:
     """Verify startup and shutdown lifecycle behavior."""
 
-    def test_startup_initializes_runtime_dependencies(self, monkeypatch):
+    def test_startup_initializes_runtime_dependencies(self, monkeypatch, tmp_path):
         """Startup initializes logging, schema, directories, and worker resources."""
         calls = []
 
-        monkeypatch.setattr("transcription.app.setup_logging", lambda: calls.append("logging"))
-        monkeypatch.setattr("transcription.app.create_all", lambda **_kwargs: calls.append("schema"))
+        monkeypatch.setattr("transcription.app.configure_logging", lambda: calls.append("logging"))
+
+        async def _create_all(**_kwargs):
+            calls.append("schema")
+
+        monkeypatch.setattr("transcription.app.create_all", _create_all)
         monkeypatch.setattr(
             "transcription.app.initialize_database_runtime",
-            lambda **_kwargs: type("_Runtime", (), {"engine": object()})(),
+            lambda **_kwargs: type("_Runtime", (), {"engine": object(), "session_factory": object()})(),
         )
-        monkeypatch.setattr("transcription.app.dispose_database_runtime", lambda: calls.append("dispose_db"))
-        monkeypatch.setattr("transcription.app.should_bootstrap_schema", lambda _settings: True)
-        monkeypatch.setattr("transcription.app._start_worker", lambda _app: calls.append("start_worker"))
-        monkeypatch.setattr("transcription.app._stop_worker", lambda _app: calls.append("stop_worker"))
 
-        class _Dir:
-            def mkdir(self, parents: bool, exist_ok: bool):
-                calls.append("mkdir")
+        async def _dispose_runtime():
+            calls.append("dispose_db")
+
+        monkeypatch.setattr("transcription.app.dispose_database_runtime", _dispose_runtime)
+
+        async def _recover_stale(_app):
+            calls.append("recover")
+
+        monkeypatch.setattr("transcription.app._recover_stale_processing_jobs", _recover_stale)
+
+        @asynccontextmanager
+        async def _worker_lifespan(**_kwargs):
+            calls.append("worker_start")
+            yield object(), object()
+            calls.append("worker_stop")
+
+        monkeypatch.setattr("transcription.app.worker_consumer_lifespan", _worker_lifespan)
 
         class _Settings:
-            upload_dir = _Dir()
-            prompt_dir = _Dir()
+            should_bootstrap_schema = True
+            upload_dir = tmp_path / "uploads"
+            prompt_dir = tmp_path / "prompts"
 
         monkeypatch.setattr("transcription.app.get_settings", lambda: _Settings())
 
@@ -52,32 +69,50 @@ class TestAppLifespan:
 
         assert "logging" in calls
         assert "schema" in calls
-        assert "mkdir" in calls
-        assert "start_worker" in calls
+        assert "recover" in calls
+        assert "worker_start" in calls
+        assert "worker_stop" in calls
         assert "dispose_db" in calls
+        assert _Settings.upload_dir.exists()
+        assert _Settings.prompt_dir.exists()
 
-    def test_shutdown_stops_worker_resources(self, monkeypatch):
+    def test_shutdown_stops_worker_resources(self, monkeypatch, tmp_path):
         """Shutdown signals and stops worker resources cleanly."""
         calls = []
 
-        monkeypatch.setattr("transcription.app.setup_logging", lambda: None)
-        monkeypatch.setattr("transcription.app.create_all", lambda **_kwargs: None)
+        monkeypatch.setattr("transcription.app.configure_logging", lambda: calls.append("logging"))
+
+        async def _create_all(**_kwargs):
+            calls.append("schema")
+
+        monkeypatch.setattr("transcription.app.create_all", _create_all)
         monkeypatch.setattr(
             "transcription.app.initialize_database_runtime",
-            lambda **_kwargs: type("_Runtime", (), {"engine": object()})(),
+            lambda **_kwargs: type("_Runtime", (), {"engine": object(), "session_factory": object()})(),
         )
-        monkeypatch.setattr("transcription.app.dispose_database_runtime", lambda: calls.append("dispose_db"))
-        monkeypatch.setattr("transcription.app.should_bootstrap_schema", lambda _settings: True)
-        monkeypatch.setattr("transcription.app._start_worker", lambda _app: calls.append("start_worker"))
-        monkeypatch.setattr("transcription.app._stop_worker", lambda _app: calls.append("stop_worker"))
 
-        class _Dir:
-            def mkdir(self, parents: bool, exist_ok: bool):
-                return None
+        async def _dispose_runtime():
+            calls.append("dispose_db")
+
+        monkeypatch.setattr("transcription.app.dispose_database_runtime", _dispose_runtime)
+
+        async def _recover_stale(_app):
+            calls.append("recover")
+
+        monkeypatch.setattr("transcription.app._recover_stale_processing_jobs", _recover_stale)
+
+        @asynccontextmanager
+        async def _worker_lifespan(**_kwargs):
+            calls.append("worker_start")
+            yield object(), object()
+            calls.append("worker_stop")
+
+        monkeypatch.setattr("transcription.app.worker_consumer_lifespan", _worker_lifespan)
 
         class _Settings:
-            upload_dir = _Dir()
-            prompt_dir = _Dir()
+            should_bootstrap_schema = True
+            upload_dir = tmp_path / "uploads"
+            prompt_dir = tmp_path / "prompts"
 
         monkeypatch.setattr("transcription.app.get_settings", lambda: _Settings())
 
@@ -85,4 +120,4 @@ class TestAppLifespan:
         with TestClient(app):
             pass
 
-        assert calls == ["start_worker", "stop_worker", "dispose_db"]
+        assert calls == ["logging", "schema", "recover", "worker_start", "worker_stop", "dispose_db"]