Github Copilot service realignment & cleanup

tests/services/test_store.py

@@ -9,31 +9,33 @@ from transcription.db.models import Document
 from transcription.db.models import Job
 from transcription.db.models import JobSource
 from transcription.db.models import Source
-from transcription.services.store import UploadError
-from transcription.services.store import create_upload_job
+from transcription.services.people import store_person_portrait
+from transcription.services.sources import source_mime_type
+from transcription.services.store import SourceStorageError
+from transcription.services.store import create_document_job
 from transcription.services.store import create_job_for_document
-from transcription.services.store import store_person_portrait
+from transcription.services.store import store_source_file
 
 
 @pytest.mark.asyncio
-async def test_create_job_for_document_requires_at_least_one_upload(async_session, tmp_path):
+async def test_create_job_for_document_requires_at_least_one_source(async_session, tmp_path):
     document = Document(id=uuid4(), name="needs-upload")
     async_session.add(document)
     await async_session.commit()
 
     settings = Settings(openrouter_api_key="test-key", upload_dir=tmp_path)
 
-    with pytest.raises(UploadError):
+    with pytest.raises(SourceStorageError):
         await create_job_for_document(
             document_id=document.id,
-            uploads=[],
+            source_files=[],
             session=async_session,
             settings=settings,
         )
 
 
 @pytest.mark.asyncio
-async def test_create_job_for_document_sorts_uploads_and_creates_links(async_session, tmp_path):
+async def test_create_job_for_document_sorts_sources_and_creates_links(async_session, tmp_path):
     document = Document(id=uuid4(), name="ordered-upload-doc")
     async_session.add(document)
     await async_session.commit()
@@ -42,7 +44,7 @@ async def test_create_job_for_document_sorts_uploads_and_creates_links(async_ses
 
     result = await create_job_for_document(
         document_id=document.id,
-        uploads=[
+        source_files=[
             ("folder/b_page.pdf", b"b"),
             ("folder/A_page.pdf", b"a"),
         ],
@@ -61,9 +63,7 @@ async def test_create_job_for_document_sorts_uploads_and_creates_links(async_ses
 
     sources = (
         await async_session.exec(
-            select(Source)
-            .where(Source.document_id == document.id)
-            .order_by(Source.page_number)  # pyright: ignore[reportArgumentType]
+            select(Source).where(Source.document_id == document.id).order_by(Source.page_number)  # pyright: ignore[reportArgumentType]
         )
     ).all()
     assert [source.upload_name for source in sources] == ["A_page.pdf", "b_page.pdf"]
@@ -83,10 +83,10 @@ async def test_create_job_for_document_sorts_uploads_and_creates_links(async_ses
 
 
 @pytest.mark.asyncio
-async def test_create_upload_job_stores_source_under_document_id_directory(async_session, tmp_path):
+async def test_create_document_job_stores_source_under_document_id_directory(async_session, tmp_path):
     settings = Settings(openrouter_api_key="test-key", upload_dir=tmp_path)
 
-    result = await create_upload_job(
+    result = await create_document_job(
         filename="single-page.jpg",
         file_bytes=b"image-bytes",
         session=async_session,
@@ -99,9 +99,7 @@ async def test_create_upload_job_stores_source_under_document_id_directory(async
 
     source = (
         await async_session.exec(
-            select(Source)
-            .where(Source.document_id == result.document_id)
-            .order_by(Source.page_number)  # pyright: ignore[reportArgumentType]
+            select(Source).where(Source.document_id == result.document_id).order_by(Source.page_number)  # pyright: ignore[reportArgumentType]
         )
     ).first()
     assert source is not None
@@ -129,3 +127,25 @@ def test_store_person_portrait_stores_file_under_person_id_directory(tmp_path):
 
     assert stored_path.parent == (tmp_path / "persons" / str(person_id))
     assert stored_path.exists()
+
+
+@pytest.mark.parametrize(
+    ("filename", "expected_mime_type"),
+    [
+        ("page.jpg", "image/jpeg"),
+        ("page.JPEG", "image/jpeg"),
+        ("page.png", "image/png"),
+        ("page.tif", "image/tiff"),
+        ("page.TIFF", "image/tiff"),
+        ("page.pdf", "application/pdf"),
+    ],
+)
+def test_source_mime_type_uses_canonical_source_policy(filename, expected_mime_type):
+    assert source_mime_type(filename) == expected_mime_type
+
+
+def test_source_storage_rejects_unsupported_format(tmp_path):
+    settings = Settings(openrouter_api_key="test-key", upload_dir=tmp_path)
+
+    with pytest.raises(SourceStorageError):
+        store_source_file(filename="page.txt", file_bytes=b"text", settings=settings)