claude-sonnet-5 review: Phase 1 implemented by gpt-5.3-codex

tests/test_db.py

@@ -123,14 +123,19 @@ async def test_create_all_declares_hot_path_indexes(tmp_path):
         await create_all(engine=runtime.engine)
         async with runtime.engine.connect() as connection:
 
-            def collect(sync_connection) -> dict[str, list[list[str]]]:
+            def collect(sync_connection) -> tuple[dict[str, list[list[str]]], list[list[str]]]:
                 database = inspect(sync_connection)
-                return {
+                indexes = {
                     table: [index["column_names"] for index in database.get_indexes(table)]
                     for table in ("job", "source", "job_source", "document", "document_person")
                 }
+                job_source_unique = [
+                    constraint["column_names"]
+                    for constraint in database.get_unique_constraints("job_source")
+                ]
+                return indexes, job_source_unique
 
-            indexes = await connection.run_sync(collect)
+            indexes, job_source_unique = await connection.run_sync(collect)
 
         assert ["status", "date_created"] in indexes["job"]
         assert ["document_id"] in indexes["job"]
@@ -138,6 +143,7 @@ async def test_create_all_declares_hot_path_indexes(tmp_path):
         assert ["preferred_execution_attempt_id"] in indexes["source"]
         assert ["job_id"] in indexes["job_source"]
         assert ["source_id"] in indexes["job_source"]
+        assert ["job_id", "source_id"] in job_source_unique
         assert ["document_type_id"] in indexes["document"]
         for column in ("document_id", "person_id", "role_id"):
             assert [column] in indexes["document_person"]