claude-sonnet-5 review: Phase 1 implemented by gpt-5.3-codex

tests/services/test_v2_crud.py

@@ -14,6 +14,7 @@ from transcription.errors import ErrorCategory
 from transcription.services.documents import DocumentDeleteBlockedError
 from transcription.services.documents import DocumentService
 from transcription.services.errors import SourceDeleteBlockedError
+from transcription.services.errors import TranscriptionError
 from transcription.services.evidence import EvidenceService
 from transcription.services.jobs import JobService
 from transcription.services.people import PeopleError
@@ -190,6 +191,37 @@ async def test_transcription_service_job_source_crud_uses_caller_session(default
     assert len(await transcriptions.list_job_sources(job_id=job.id)) == 0
 
 
+@pytest.mark.asyncio
+async def test_create_job_source_rejects_duplicate_job_source_membership(default_session_factory):
+    documents = DocumentService(session_factory=default_session_factory)
+    jobs = JobService(session_factory=default_session_factory)
+    transcriptions = SourceService(session_factory=default_session_factory)
+
+    document = await documents.create_document(Document(id=uuid4(), name="duplicate-job-source-doc"))
+    job = await jobs.create_job(Job(document_id=document.id))
+    source = await transcriptions.create_source(
+        Source(
+            document_id=document.id,
+            page_number=1,
+            upload_name="duplicate.jpg",
+            filename="duplicate.jpg",
+            file_path="uploads/duplicate.jpg",
+            file_hash="d" * 64,
+            file_size_bytes=1,
+        )
+    )
+    await transcriptions.create_job_source(
+        JobSource(job_id=job.id, source_id=source.id, status=JobSourceStatus.PENDING)
+    )
+
+    with pytest.raises(TranscriptionError) as duplicate:
+        await transcriptions.create_job_source(
+            JobSource(job_id=job.id, source_id=source.id, status=JobSourceStatus.PENDING)
+        )
+
+    assert duplicate.value.category == ErrorCategory.CONFLICT
+
+
 @pytest.mark.asyncio
 async def test_document_detail_loads_linked_person_relationship(default_session_factory):
     documents = DocumentService(session_factory=default_session_factory)