gpt-5.3 codex review: Phase 7 and the addition of the new test-effectiveness-auditor skill.

tests/test_config.py

@@ -1,5 +1,7 @@
 """Tests for transcription.config — settings loading, provider defaults, and paths."""
 
+import logging
+from logging.handlers import RotatingFileHandler
 from pathlib import Path
 from typing import Any
 
@@ -8,6 +10,7 @@ from pydantic import ValidationError
 
 from transcription.config import Provider
 from transcription.config import Settings
+from transcription.config import configure_logging
 from transcription.config import parse_cli_settings
 
 
@@ -141,6 +144,20 @@ class TestPathSettings:
         settings = _make_settings()
         assert isinstance(settings.upload_dir, Path)
         assert isinstance(settings.prompt_dir, Path)
+        assert isinstance(settings.log_dir, Path)
+        assert isinstance(settings.database_backup_dir, Path)
+
+
+def test_configure_logging_writes_rotating_file_logs_to_configured_directory(tmp_path):
+    log_dir = tmp_path / "logs"
+    settings = _make_settings(log_dir=log_dir, log_file_name="app.log")
+
+    configure_logging(settings)
+
+    root_handlers = logging.getLogger().handlers
+    file_handlers = [handler for handler in root_handlers if isinstance(handler, RotatingFileHandler)]
+    assert file_handlers
+    assert Path(file_handlers[0].baseFilename) == log_dir / "app.log"
 
 
 class TestWorkerReliabilitySettings: