gpt-5.3 codex review: Phase 7 and the addition of the new test-effectiveness-auditor skill.

2026-08-20 11:50:10 -05:00
parent 443a1e29c8
commit 7c4300f9c2
21 changed files with 831 additions and 119 deletions
@@ -87,11 +87,15 @@ async def test_promotion_rejects_unrelated_attempt(default_session_factory):
    services = _services(default_session_factory, settings)
    source = await _seed_source(services)

-    with pytest.raises(CandidatePromotionError):
+    with pytest.raises(CandidatePromotionError) as exc_info:
        await services.evidence.promote_machine_attempt(
            source_id=source.id,
            execution_attempt_id=uuid4(),
        )
+    error = exc_info.value
+    assert error.category.value == "validation_error"
+    assert "successful transcription attempt" in error.message
+    assert "Select an available successful candidate" in error.suggestion


@pytest.mark.integration