ruff linting

tests/api/test_access_control.py

@@ -5,18 +5,19 @@ from __future__ import annotations
 import base64
 from types import SimpleNamespace
 
+import pytest
 from fastapi import FastAPI
 from fastapi.responses import JSONResponse
 from fastapi.testclient import TestClient
-import pytest
 
 from transcription.api.errors import register_error_handlers
 from transcription.errors import build_error_envelope
-from transcription.security import AccessDeniedError, enforce_request_access
+from transcription.security import AccessDeniedError
+from transcription.security import enforce_request_access
 
 
 def _basic_header(username: str, password: str) -> str:
-    token = base64.b64encode(f"{username}:{password}".encode("utf-8")).decode("ascii")
+    token = base64.b64encode(f"{username}:{password}".encode()).decode("ascii")
     return f"Basic {token}"
 
 
@@ -125,4 +126,4 @@ class TestAccessControl:
         response = client.get("/healthz")
 
         assert response.status_code == 200
-        assert response.json() == {"status": "ok"}
+        assert response.json() == {"status": "ok"}

tests/api/test_error_responses.py

@@ -1,11 +1,12 @@
 """Tests for API error response envelope handlers."""
 
+import pytest
 from fastapi import FastAPI
 from fastapi.testclient import TestClient
-import pytest
 
 from transcription.api.errors import register_error_handlers
-from transcription.errors import AppError, ErrorCategory
+from transcription.errors import AppError
+from transcription.errors import ErrorCategory
 
 
 @pytest.mark.integration

tests/api/test_routes.py

@@ -1,12 +1,13 @@
 """Tests for Step 3 functional API routes."""
 
-from datetime import datetime, timezone
+from datetime import UTC
+from datetime import datetime
 from types import SimpleNamespace
 from uuid import uuid4
 
+import pytest
 from fastapi import FastAPI
 from fastapi.testclient import TestClient
-import pytest
 
 from transcription.api.errors import register_error_handlers
 from transcription.api.routes import router
@@ -25,7 +26,7 @@ class TestFunctionalRoutes:
 
     def test_get_jobs_returns_serialized_rows(self, monkeypatch):
         """GET /api/jobs returns normalized job rows."""
-        now = datetime.now(timezone.utc)
+        now = datetime.now(UTC)
         job = SimpleNamespace(
             id=uuid4(),
             document_id=uuid4(),
@@ -53,7 +54,7 @@ class TestFunctionalRoutes:
             text="edited text",
             source="user",
             accepted=False,
-            created_at=datetime.now(timezone.utc),
+            created_at=datetime.now(UTC),
         )
         monkeypatch.setattr("transcription.api.routes.add_revision", lambda **_kwargs: revision)
 
@@ -78,7 +79,7 @@ class TestFunctionalRoutes:
             text="family archive",
             source="user",
             accepted=True,
-            created_at=datetime.now(timezone.utc),
+            created_at=datetime.now(UTC),
         )
         monkeypatch.setattr("transcription.api.routes.search_accepted_transcripts", lambda query: [result])
 
@@ -103,7 +104,7 @@ class TestFunctionalRoutes:
                 "accepted": True,
                 "source": "user",
                 "text": "exported",
-                "created_at": datetime.now(timezone.utc).isoformat(),
+                "created_at": datetime.now(UTC).isoformat(),
             }
         ]
         monkeypatch.setattr("transcription.api.routes.export_transcripts", lambda accepted_only=True: records)

tests/conftest.py

@@ -5,7 +5,9 @@ isolated, fast, and leave no artifacts on disk.
 """
 
 import pytest
-from sqlmodel import Session, SQLModel, create_engine
+from sqlmodel import Session
+from sqlmodel import SQLModel
+from sqlmodel import create_engine
 from sqlmodel.pool import StaticPool
 
 

tests/integration/test_pipeline_flow.py

@@ -6,7 +6,9 @@ import pytest
 from sqlmodel import select
 
 from transcription.config import Settings
-from transcription.models import Job, JobStatus, Transcript
+from transcription.models import Job
+from transcription.models import JobStatus
+from transcription.models import Transcript
 from transcription.providers.base import TranscriptionResult
 from transcription.services.upload import create_upload_job
 from transcription.worker import process_next_queued_job

tests/providers/test_openrouter.py

@@ -5,8 +5,10 @@ from types import SimpleNamespace
 import pytest
 
 from transcription.config import Settings
-from transcription.providers.base import ProviderError, ProviderResponseError
-from transcription.providers.openrouter import DEFAULT_OPENROUTER_MODEL, OpenRouterTranscriptionProvider
+from transcription.providers.base import ProviderError
+from transcription.providers.base import ProviderResponseError
+from transcription.providers.openrouter import DEFAULT_OPENROUTER_MODEL
+from transcription.providers.openrouter import OpenRouterTranscriptionProvider
 
 
 class _FakeChat:

tests/services/test_library.py

@@ -1,10 +1,18 @@
 """Tests for Step 3 library services (revisions, search, export)."""
 
-from sqlmodel import select
 import pytest
+from sqlmodel import select
 
-from transcription.models import Document, Job, JobStatus, Transcript, TranscriptRevision
-from transcription.services.library import accept_revision, add_revision, export_transcripts, list_revisions, search_accepted_transcripts
+from transcription.models import Document
+from transcription.models import Job
+from transcription.models import JobStatus
+from transcription.models import Transcript
+from transcription.models import TranscriptRevision
+from transcription.services.library import accept_revision
+from transcription.services.library import add_revision
+from transcription.services.library import export_transcripts
+from transcription.services.library import list_revisions
+from transcription.services.library import search_accepted_transcripts
 
 
 def _create_job(session) -> Job:

tests/services/test_transcription.py

@@ -5,14 +5,13 @@ from pathlib import Path
 import pytest
 
 from transcription.config import Settings
-from transcription.providers.base import ProviderError, TranscriptionResult
-from transcription.services.transcription import (
-    PromptLoadError,
-    TranscriptionError,
-    load_image_payload,
-    load_prompt_text,
-    transcribe_document_image,
-)
+from transcription.providers.base import ProviderError
+from transcription.providers.base import TranscriptionResult
+from transcription.services.transcription import PromptLoadError
+from transcription.services.transcription import TranscriptionError
+from transcription.services.transcription import load_image_payload
+from transcription.services.transcription import load_prompt_text
+from transcription.services.transcription import transcribe_document_image
 
 
 class _FakeProvider:

tests/services/test_transcription_external.py

@@ -7,7 +7,6 @@ import pytest
 
 from transcription.services.transcription import transcribe_document_image
 
-
 HAS_OPENROUTER_KEY = bool(os.getenv("OPENROUTER_API_KEY"))
 
 REAL_IMAGES_DIR = Path(__file__).resolve().parents[1] / "fixtures" / "images" / "real"
@@ -67,4 +66,4 @@ class TestRealImageExternalTranscription:
             f"{result.text}\n"
         )
         artifact_path.write_text(artifact_text, encoding="utf-8")
-        assert artifact_path.exists()
+        assert artifact_path.exists()

tests/services/test_upload.py

@@ -5,8 +5,11 @@ from pathlib import Path
 import pytest
 
 from transcription.config import Settings
-from transcription.models import Document, Job, JobStatus
-from transcription.services.upload import UploadError, create_upload_job
+from transcription.models import Document
+from transcription.models import Job
+from transcription.models import JobStatus
+from transcription.services.upload import UploadError
+from transcription.services.upload import create_upload_job
 
 
 @pytest.mark.unit

tests/services/test_worker.py

@@ -7,10 +7,16 @@ import pytest
 from sqlmodel import select
 
 from transcription.config import Settings
-from transcription.errors import AppError, ErrorCategory
-from transcription.models import Document, Job, JobStatus, Transcript, TranscriptRevision
+from transcription.errors import AppError
+from transcription.errors import ErrorCategory
+from transcription.models import Document
+from transcription.models import Job
+from transcription.models import JobStatus
+from transcription.models import Transcript
+from transcription.models import TranscriptRevision
 from transcription.providers.base import TranscriptionResult
-from transcription.worker import process_next_queued_job, run_worker_loop
+from transcription.worker import process_next_queued_job
+from transcription.worker import run_worker_loop
 
 
 def _create_queued_job(session, *, filename: str = "doc.jpg", file_path: str = "uploads/doc.jpg") -> Job:

tests/test_config.py

@@ -5,7 +5,8 @@ from pathlib import Path
 import pytest
 from pydantic import ValidationError
 
-from transcription.config import Provider, Settings
+from transcription.config import Provider
+from transcription.config import Settings
 
 
 def _make_settings(**overrides) -> Settings:

tests/test_db.py

@@ -1,7 +1,10 @@
 """Tests for transcription.db — schema bootstrap and session factory."""
 
-from sqlalchemy import inspect, text
-from sqlmodel import Session, SQLModel, create_engine
+from sqlalchemy import inspect
+from sqlalchemy import text
+from sqlmodel import Session
+from sqlmodel import SQLModel
+from sqlmodel import create_engine
 from sqlmodel.pool import StaticPool
 
 
@@ -21,9 +24,11 @@ class TestSchemaBootstrap:
         """After create_all(), core V1 tables exist."""
         engine = _in_memory_engine()
         # Ensure models are imported so metadata is populated
-        from transcription.models import Document, Job, Transcript, TranscriptRevision  # noqa: F401
-
         import transcription.db as db_module
+        from transcription.models import Document  # noqa: F401
+        from transcription.models import Job  # noqa: F401
+        from transcription.models import Transcript  # noqa: F401
+        from transcription.models import TranscriptRevision  # noqa: F401
 
         db_module.create_all(engine=engine)
 
@@ -34,7 +39,6 @@ class TestSchemaBootstrap:
         assert "transcript" in table_names
         assert "transcriptrevision" in table_names
 
-
     def test_validate_schema_compatibility_returns_no_issues_for_fresh_schema(self):
         """validate_schema_compatibility reports no issues on fresh schema."""
         engine = _in_memory_engine()

tests/test_errors.py

@@ -2,7 +2,10 @@
 
 import pytest
 
-from transcription.errors import AppError, ErrorCategory, classify_unexpected_error, new_error_id
+from transcription.errors import AppError
+from transcription.errors import ErrorCategory
+from transcription.errors import classify_unexpected_error
+from transcription.errors import new_error_id
 
 
 @pytest.mark.unit

tests/test_migrations.py

@@ -1,10 +1,12 @@
 """Tests for transcription.migrations — explicit Step 4 migration safety behavior."""
 
-from sqlalchemy import inspect, text
+from sqlalchemy import inspect
+from sqlalchemy import text
 from sqlmodel import create_engine
 from sqlmodel.pool import StaticPool
 
-from transcription.migrations import apply_pending_migrations, list_pending_migrations
+from transcription.migrations import apply_pending_migrations
+from transcription.migrations import list_pending_migrations
 
 
 def _in_memory_engine():
@@ -103,4 +105,4 @@ class TestMigrations:
         second_apply = apply_pending_migrations(engine=engine)
 
         assert len(first_apply) == 2
-        assert second_apply == []
+        assert second_apply == []

tests/test_models.py

@@ -5,7 +5,11 @@ from uuid import UUID
 import pytest
 from sqlalchemy.exc import IntegrityError
 
-from transcription.models import Document, Job, JobStatus, Transcript, TranscriptRevision
+from transcription.models import Document
+from transcription.models import Job
+from transcription.models import JobStatus
+from transcription.models import Transcript
+from transcription.models import TranscriptRevision
 
 
 def _make_document(**overrides) -> Document:

tests/test_prompts.py

@@ -2,7 +2,6 @@
 
 from pathlib import Path
 
-
 PROMPT_PATH = Path("prompts/transcribe_document.md")
 
 

tests/ui/test_jobs_page.py

@@ -4,8 +4,11 @@ from uuid import uuid4
 
 import pytest
 
-from transcription.models import Document, Job, Transcript
-from transcription.ui.jobs_page import fetch_job_detail, fetch_jobs
+from transcription.models import Document
+from transcription.models import Job
+from transcription.models import Transcript
+from transcription.ui.jobs_page import fetch_job_detail
+from transcription.ui.jobs_page import fetch_jobs
 
 
 @pytest.mark.integration

tests/ui/test_pages_registration.py

@@ -1,8 +1,8 @@
 """Tests for UI page registration wiring."""
 
+import pytest
 from fastapi import FastAPI
 from fastapi.testclient import TestClient
-import pytest
 
 from transcription.ui import register_pages
 

tests/ui/test_upload_page.py

@@ -5,7 +5,8 @@ from uuid import uuid4
 
 import pytest
 
-from transcription.services.upload import UploadError, UploadJobResult
+from transcription.services.upload import UploadError
+from transcription.services.upload import UploadJobResult
 from transcription.ui import upload_page