generated from john/python-template
V4.6 Phase 7: drive ty check to zero and add a blocking quality gate [HIGH-06]
Baseline was 207 diagnostics. Two real bugs were hiding in the noise: - tools/run_destructive_tests.py imported ctypes.wintypes at module scope, which raises on non-Windows, and called fcntl unconditionally. The Windows and POSIX implementations now live under a module-level sys.platform split. - tests/ui/test_sources_page.py constructed Source(...) without document_id. Structural fixes, not suppressions: - New src/transcription/db/loading.py owns the SQLModel-field to QueryableAttribute reinterpretation via orm_attribute()/selectinload()/ defer(). This removed 42 "# pyright: ignore[reportArgumentType]" comments across documents/jobs/people/sources. Its docstring records that selectinload(A.b, B.c) is NOT equivalent to the chained form: varargs applies the selectin strategy only to the last path element, which under lazy="raise" raises InvalidRequestError at render time. - db/session.py transaction_scope no longer accepts or yields AsyncSessionTransaction. No caller ever passed one, sessionmaker.begin() yields an AsyncSession, and the dead branch was latently buggy because services call .exec(). Cleared 7 workflows.py diagnostics. - services/registry.py RegistryService is bound by a new RegistryEntry Protocol instead of bare SQLModel, so the shared implementation can read id/label/normalized_label/is_active. Cleared 9 diagnostics. - Column expressions in sources.py/jobs.py/test_store.py wrap in sqlmodel col(), the idiom already used in registry.py. - read_source_navigation wraps its literal tuple bounds in literal(). - normalization.py narrows with isinstance(image, TiffImageFile) rather than comparing image.format, since tag_v2 is TIFF-only. - linked_people.render uses @ui.refreshable_method, the NiceGUI API for bound methods. - The OpenRouter capturing client re-raises ResponseNotRead when the response stream is not async rather than mis-wrapping it. Tooling gate: - New .pre-commit-config.yaml runs ruff check and ty check as blocking hooks. No pre-commit config previously existed. Negative-tested: injecting a type error fails both hooks. - The last two "# pyright: ignore" comments (config.py) are removed; ty does not honor pyright directives. One "# ty: ignore" remains, in tests/test_prompts.py, where the test deliberately assigns to a frozen field to assert ValidationError. - asyncio_default_fixture_loop_scope is pinned to "function" so pytest-asyncio behavior does not shift on upgrade. Verification: ruff check clean, ty check reports 0 diagnostics, 292 passed and 4 skipped, pre-commit passes and demonstrably fails on a regression, and tools/run_destructive_tests.py runs on Windows. Co-authored-by: Copilot App <[email protected]>
This commit is contained in:
@@ -1,5 +1,6 @@
|
||||
"""Tests for the V2 SQLModel persistence layer and relationships."""
|
||||
|
||||
from typing import Any
|
||||
from uuid import UUID
|
||||
|
||||
import pytest
|
||||
@@ -17,8 +18,8 @@ from transcription.db.models import PersonRole
|
||||
from transcription.db.models import Source
|
||||
|
||||
|
||||
def _make_document(**overrides) -> Document:
|
||||
defaults = {
|
||||
def _make_document(**overrides: Any) -> Document:
|
||||
defaults: dict[str, Any] = {
|
||||
"name": "letter bundle",
|
||||
"notes": "Family correspondence",
|
||||
}
|
||||
@@ -51,8 +52,8 @@ def _persist_document(session) -> Document:
|
||||
return document
|
||||
|
||||
|
||||
def _persist_person(session, **overrides) -> Person:
|
||||
defaults = {"full_name": "Ada Lovelace"}
|
||||
def _persist_person(session, **overrides: Any) -> Person:
|
||||
defaults: dict[str, Any] = {"full_name": "Ada Lovelace"}
|
||||
defaults.update(overrides)
|
||||
person = Person(**defaults)
|
||||
session.add(person)
|
||||
@@ -69,8 +70,8 @@ def _persist_job(session, document: Document) -> Job:
|
||||
return job
|
||||
|
||||
|
||||
def _persist_source(session, document: Document, *, page_number: int = 1, **overrides) -> Source:
|
||||
defaults = {
|
||||
def _persist_source(session, document: Document, *, page_number: int = 1, **overrides: Any) -> Source:
|
||||
defaults: dict[str, Any] = {
|
||||
"document_id": document.id,
|
||||
"page_number": page_number,
|
||||
"upload_name": "letter.jpg",
|
||||
@@ -88,8 +89,8 @@ def _persist_source(session, document: Document, *, page_number: int = 1, **over
|
||||
return source
|
||||
|
||||
|
||||
def _persist_job_source(session, job: Job, source: Source, **overrides) -> JobSource:
|
||||
defaults = {
|
||||
def _persist_job_source(session, job: Job, source: Source, **overrides: Any) -> JobSource:
|
||||
defaults: dict[str, Any] = {
|
||||
"job_id": job.id,
|
||||
"source_id": source.id,
|
||||
"status": JobSourceStatus.PENDING,
|
||||
|
||||
Reference in New Issue
Block a user