Step 6 implemented

2026-06-25 11:08:26 -05:00
parent 759c8c2739
commit 643c523ed4
7 changed files with 293 additions and 36 deletions
@@ -0,0 +1,70 @@
+Step 5 is implemented and passing ✅
+
+### What I implemented
+
+#### App/bootstrap
+- Added `src/transcription/app.py`:
+  - `create_app()` factory
+  - FastAPI lifespan startup/shutdown:
+    - `setup_logging()`
+    - `create_all()`
+    - ensure `upload_dir` and `prompt_dir`
+    - start/stop worker thread (`run_worker_loop`)
+  - includes health router
+  - registers NiceGUI pages
+
+#### API
+- Added `src/transcription/api/__init__.py`
+- Added `src/transcription/api/health.py`:
+  - `GET /healthz` returns `{"status": "ok"}`
+
+#### UI
+- Added `src/transcription/ui/upload_page.py`:
+  - upload page route
+  - accepted extensions helper
+  - upload submit helper to Step 4 service (`create_upload_job`)
+  - success/error state messaging
+- Added `src/transcription/ui/jobs_page.py`:
+  - jobs list page
+  - job detail page
+  - `fetch_jobs()` and `fetch_job_detail()` helpers
+- Updated `src/transcription/ui/__init__.py`:
+  - explicit page registration
+  - NiceGUI mounted via `ui.run_with(app, mount_path="/ui", ...)`
+
+#### Dependencies
+- Added runtime dependencies:
+  - `fastapi`
+  - `nicegui`
+
+---
+
+### Tests created and filled (scaffold → fill)
+
+- `tests/test_app.py`
+- `tests/api/test_health.py`
+- `tests/ui/test_pages_registration.py`
+- `tests/ui/test_upload_page.py`
+- `tests/ui/test_jobs_page.py`
+
+All scaffolded method names/docstrings were preserved and filled with executable assertions.
+
+---
+
+### Validation results (strict sequence)
+
+- `uv run pytest --collect-only -q` ✅
+- `uv run pytest -m unit -q` ✅
+- `uv run pytest tests/api/test_health.py -q` ✅
+- `uv run pytest tests/ui/test_pages_registration.py -q` ✅
+- `uv run pytest tests/test_app.py -q` ✅
+- `uv run pytest tests/ui/test_upload_page.py -q` ✅
+- `uv run pytest tests/ui/test_jobs_page.py -q` ✅
+- `uv run pytest -q` ✅
+
+Full suite is green.
+
+---
+
+### Note
+You’ll see one warning from FastAPI/Starlette test client about `httpx` deprecation; it does not affect correctness and all tests pass.
@@ -0,0 +1,50 @@
+Step 6 implemented ✅
+
+### Files added
+- `tests/integration/test_pipeline_flow.py`
+- `tests/test_traceability.py`
+
+### What was implemented
+
+#### 1) End-to-end pipeline integration coverage
+`tests/integration/test_pipeline_flow.py` now verifies:
+
+- **Success path**
+  - upload creates queued job
+  - worker processes job
+  - job becomes `transcribed`
+  - transcript text is persisted
+  - error detail remains `None`
+
+- **Failure path**
+  - upload creates queued job
+  - worker processing failure is handled
+  - job becomes `failed`
+  - transcript has `text=None`
+  - `error_detail` contains provider failure reason
+
+#### 2) MVP requirement traceability check
+`tests/test_traceability.py` adds a concrete map:
+
+- REQ-0, REQ-1, REQ-2, REQ-3, REQ-4, REQ-5, REQ-6, REQ-8, REQ-12
+- each REQ maps to one or more existing test files
+- test asserts each mapped path exists (guards against drift)
+
+---
+
+### Validation run results
+
+Executed and passed:
+
+1. `uv run pytest --collect-only -q` ✅  
+2. `uv run pytest -m unit -q` ✅  
+3. `uv run pytest -m integration -q` ✅  
+4. `uv run pytest -m "not external" -q` ✅  
+5. `uv run pytest tests/integration/test_pipeline_flow.py -q` ✅  
+6. `uv run pytest tests/ui/test_upload_page.py -q` ✅  
+7. `uv run pytest tests/ui/test_jobs_page.py -q` ✅  
+8. `uv run pytest -q` ✅  
+
+All green.  
+(Only existing non-blocking FastAPI TestClient deprecation warning remains.)
+