v4.10 revision to remove "legacy compatibility" code

tests/services/test_store.py

@@ -73,7 +73,10 @@ async def test_create_job_for_document_sorts_sources_and_creates_links(async_ses
     assert all(source.filename.endswith(".pdf") for source in sources)
     assert all("A_page" not in source.filename and "b_page" not in source.filename for source in sources)
     assert all(Path(source.filename).stem == str(source.id) for source in sources)
-    assert all(Path(source.file_path).parent == (tmp_path / "documents" / str(document.id)) for source in sources)
+    assert all(
+        source.file_path == f"documents/{document.id}/{source.filename}"
+        for source in sources
+    )
     assert [source.file_hash for source in sources] == [
         "ca978112ca1bbdcafac231b39a23dc4da786eff8147c4e72b9807785afee48bb",
         "3e23e8160039594a33894f6564e1b1348bbd7a0088d42c4acb73eeaed59c009d",
@@ -108,7 +111,7 @@ async def test_create_document_job_stores_source_under_document_id_directory(asy
     assert source is not None
     assert Path(source.filename).stem == str(source.id)
     assert result.stored_path.name == source.filename
-    assert Path(source.file_path).parent == expected_parent
+    assert source.file_path == f"documents/{result.document_id}/{source.filename}"
     assert source.file_hash == "2c8648d103e3dd7ad87660da0f126a1443b6d21ac1bd3ec000c5e24e2373a90c"
     assert source.file_size_bytes == len(b"image-bytes")