v4.10 revision to remove "legacy compatibility" code

tests/services/test_settings_services.py

@@ -34,7 +34,7 @@ async def test_document_type_maintenance_uses_alphabetical_labels(default_sessio
 
     summaries = await service.list_document_type_summaries()
     assert [item.label for item in summaries] == ["Archive", "Letter"]
-    assert [item.document_count for item in summaries] == [0, 0]
+    assert [item.reference_count for item in summaries] == [0, 0]
 
 
 @pytest.mark.asyncio
@@ -56,7 +56,7 @@ async def test_document_type_delete_allows_unreferenced_and_blocks_referenced(de
     await service.create_document(Document(id=uuid4(), name="Typed document", document_type_id=referenced.id))
 
     summaries = {item.id: item for item in await service.list_document_type_summaries()}
-    assert summaries[referenced.id].document_count == 1
+    assert summaries[referenced.id].reference_count == 1
 
     await service.delete_document_type(unused.id)
     with pytest.raises(DocumentTypeError) as caught:
@@ -84,7 +84,7 @@ async def test_person_role_maintenance_orders_by_normalized_label(default_sessio
     assert [item.id for item in await service.list_person_roles(active_only=False)] == [first.id, second.id]
     assert [item.id for item in await service.list_person_roles()] == [first.id]
     summaries = {item.id: item for item in await service.list_person_role_summaries()}
-    assert summaries[second.id].link_count == 0
+    assert summaries[second.id].reference_count == 0
     assert summaries[second.id].is_built_in is False