Align python-code-reviewer skill with repo ground truth

Update the reviewer skill so its procedure matches how this repo actually works: - Route review reports to docs/reviews/ and mark them non-canonical, resolving the conflict where reports landed in the same docs/ tree they resolve findings against. - Pin verification commands to uv (uv run ruff check / ty check / pytest -m 'not external'). - Record the pytest contract: strict markers, strict asyncio mode, and the never-awaited-coroutine warning promoted to an error. - Convert the deterministic checks to a table with an Enforced by column; three checks are unenforced and one only partial, which are now findings by construction. - Add a consequence-based severity rubric and a Direction column for bidirectional drift. - Escalate test-suite concerns to test-effectiveness-auditor. Also fix tests/test_db.py, which was missing 'from sqlalchemy import text' while using it in 14 places. Three tests were failing with NameError. Wrapped the pre-existing long lines in the same file so it lints clean. Document the deliberate nicegui==3.13.0 pin in pyproject.toml, a new runbook dependency upgrade policy, and the reviewer skill, so the pin is not flagged as a defect or widened as incidental cleanup. Co-authored-by: Copilot App <[email protected]>
2026-08-23 16:27:44 -05:00
parent ed6998d8da
commit 5566f48fc0
5 changed files with 104 additions and 19 deletions
@@ -15,6 +15,10 @@ dependencies = [
    "aiosqlite>=0.21.0",
    "asyncpg>=0.31.0",
    "fastapi>=0.138.0",
+    # Exact pin, deliberate. NiceGUI 3.x minor releases ship Quasar/Vue changes that
+    # break component props and styling, and tests/ui/ cannot detect visual regressions.
+    # Hold through the current release stabilization; revisit as a scheduled upgrade.
+    # See docs/production-runbook.md, "Dependency upgrade policy".
    "nicegui==3.13.0",
    "openrouter>=0.7.0",
    "pillow>=10.0.0",