gpt-5.3-codex review phase 1 - Flatten the documentation

2026-08-19 14:54:24 -05:00
parent 2c26177d0c
commit 5404224079
32 changed files with 358 additions and 4467 deletions
@@ -31,6 +31,16 @@ Perform thorough, evidence-based code reviews for Python projects. Every finding
 4. **Prioritize Hot Paths:** Focus deeply on request handling, database sessions, background workers, and external API calls.
 5. **Enforce Read-Only Safety:** Do not modify code unless explicitly instructed.

+## Repo-Specific Deterministic Checks (Transcription)
+
+When reviewing this repository, always include explicit pass/fail checks for:
+
+1. **Service boundary rule:** no service-to-service imports (`tests/test_service_boundaries.py`).
+2. **UI boundary rule:** pages/components do not perform persistence access (`tests/test_ui_boundaries.py`).
+3. **Status vocabulary conformance:** `JobStatus`/`JobSourceStatus` usage matches current enums in `src/transcription/db/models.py`.
+4. **Evidence ownership conformance:** append-only attempt history is preserved and projection writes are not mistaken for history mutation (`src/transcription/services/sources.py`, `src/transcription/services/evidence.py`).
+5. **Canonical V4 authority:** findings must resolve against `docs/ver4/*` first, and treat `docs/ver4/history.md` plus `docs/ver4.x/*` as historical context.
+
 ## Core Review Areas

 ### 1. Python Best Practices (3.12+)