gpt-5.3-codex review Phase 3
Quality Gate / gate (push) Successful in 34s

This commit is contained in:
Jim Lancaster
2026-08-19 20:50:21 -05:00
parent de8cdb6e1a
commit 30fcef3892
10 changed files with 25 additions and 55 deletions
+1 -2
View File
@@ -26,8 +26,7 @@ When documents disagree, use this order:
4. Durable failure behavior: [Error Handling invariant](../invariant/error_handling.md).
5. Durable AI evidence behavior: [Digital Evidence and AI Processing Provenance](../invariant/ai_evidence_and_provenance.md).
6. Data definitions and relationships: current models plus the [V4 schema](../ver4/schema_v4.md).
7. Historical context only: [V4 revision history](../ver4/history.md).
8. Implementation truth: current code and tests.
7. Implementation truth: current code and tests.
If code intentionally changes accepted page behavior, update the corresponding page contract in the same change. If code accidentally differs, correct the implementation rather than rewriting intent to match a defect.
+1 -3
View File
@@ -6,7 +6,7 @@ V4.8 is the first release since V4.5 to add **new user-facing behavior**. V4.6 w
## Dependency on V4.7
**The model-performance rollup below must not begin until V4.7 Phase 4 lands.** `duration_ms` currently measures provider call *plus* image normalization, artifact persistence, and a DB commit, while the timeout governs only the provider call. A rollup built on it would chart preprocessing time mixed with provider latency and look authoritative while quietly misleading. V4.7 Phase 1 removes normalization and artifact persistence from that window, but the commit remains inside it until Phase 4. See archived V4.7 scope boundary at `docs-v4x-archive:docs/ver4.7/scope_boundary_v4_7.md`.
**The model-performance rollup below must not begin until V4.7 Phase 4 lands.** `duration_ms` currently measures provider call *plus* image normalization, artifact persistence, and a DB commit, while the timeout governs only the provider call. A rollup built on it would chart preprocessing time mixed with provider latency and look authoritative while quietly misleading. V4.7 Phase 1 removes normalization and artifact persistence from that window, but the commit remains inside it until Phase 4.
## Candidate Features
@@ -103,8 +103,6 @@ Item 6 is not recommended.
## Related Local References
- Archived V4.7 scope boundary: `docs-v4x-archive:docs/ver4.7/scope_boundary_v4_7.md` (blocking dependency for item 5)
- Archived V4.6 scope boundary: `docs-v4x-archive:docs/ver4.6/scope_boundary_v4_6.md`
- [Architecture & Code Review Report](../architecture_code_review_2026-08-17.md)
- `.github/instructions/ui.instructions.md`
- `src/transcription/ui/homepage_store.py` - existing multi-image storage
+2 -4
View File
@@ -156,16 +156,14 @@ Responsibilities:
- Print/export media uses record-validated API endpoints to avoid direct filesystem path exposure.
- General UI media URLs are generated through shared resolver helpers to keep path handling consistent and centralized.
## Historical Context Boundary
## Scope Boundary
Superseded V4.x scope/plan/review documents were intentionally removed from the active tree and archived at git tag `docs-v4x-archive`.
Current architecture rules live only in `docs/ver4/*`; historical files are reference material only.
Current architecture rules live only in `docs/ver4/*`.
## Related References
- [System Requirements](requirements_v4.md)
- [Data Model](schema_v4.md)
- [Error Handling Policy](error_handling_v4.md)
- [V4 Revision History](history.md)
- [Error Handling invariant](../invariant/error_handling.md)
- [AI evidence invariant](../invariant/ai_evidence_and_provenance.md)
-33
View File
@@ -1,33 +0,0 @@
# V4 Revision History (Archived)
This index tracks superseded V4.x documents as historical context.
These revisions were intentionally removed from the active working tree to prevent accidental reuse by tools and AI agents.
They are preserved at immutable git tag `docs-v4x-archive`.
## Archive Map
| Revision | Archived Paths at `docs-v4x-archive` |
| :--- | :--- |
| V4.0 | `docs/ver4.0/scope_boundary_v4.md`, `docs/ver4.0/implementation_plan_v4.md` |
| V4.1 | `docs/ver4.1/scope_boundary_v4_1.md`, `docs/ver4.1/implementation_plan_v4_1.md` |
| V4.2 | `docs/ver4.2/scope_boundary_v4_2.md`, `docs/ver4.2/implementation_plan_v4_2.md` |
| V4.3 | `docs/ver4.3/scope_boundary_v4_3.md`, `docs/ver4.3/implementation_plan_v4_3.md` |
| V4.4 | `docs/ver4.4/scope_boundary_v4_4.md`, `docs/ver4.4/implementation_plan_v4_4.md` |
| V4.5 | `docs/ver4.5/scope_boundary_v4_5.md`, `docs/ver4.5/implementation_plan_v4_5.md` |
| V4.6 | `docs/ver4.6/scope_boundary_v4_6.md`, `docs/ver4.6/implementation_plan_v4_6.md`, `docs/ver4.6/review_log_v4_6.md` |
| V4.7 | `docs/ver4.7/scope_boundary_v4_7.md`, `docs/ver4.7/implementation_plan_v4_7.md`, `docs/ver4.7/review_log_v4_7.md` |
| V4.8 | `../ver4.8/feature_backlog_v4_8.md` |
To inspect archived content locally:
`git show docs-v4x-archive:docs/ver4.6/scope_boundary_v4_6.md`
## Canonical Contract Reminder
Use `docs/ver4/` for current-state requirements, architecture, schema, and error policy:
- `index_v4.md`
- `architecture_v4.md`
- `requirements_v4.md`
- `schema_v4.md`
- `error_handling_v4.md`
+1 -2
View File
@@ -8,7 +8,6 @@ This directory is the single source of truth for current V4 behavior and archite
2. [System Requirements](requirements_v4.md) for verifiable current-state requirements.
3. [Data Model](schema_v4.md) for entities, constraints, and evidence persistence rules.
4. [Error Handling Policy](error_handling_v4.md) for category, translation, and retry behavior.
5. [V4 Revision History](history.md) for superseded scope and implementation documents.
## Cross-Version Invariants
@@ -21,4 +20,4 @@ This directory is the single source of truth for current V4 behavior and archite
## Baseline Statement
The current V4 baseline includes behavior delivered through V4.7 architectural cleanup.
Versioned V4.x scope and implementation documents are retained as historical records only at git tag `docs-v4x-archive` and do not define active contracts.
Use only this `docs/ver4/*` tree for active design and implementation decisions.