bbchops/transcription
1
0
Fork 0
generated from john/python-template
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

gpt-5.3-codex review Phase 3
Quality Gate / gate (push) Successful in 34s
Details

Browse Source
This commit is contained in:
Jim Lancaster
2026-08-19 20:50:21 -05:00
parent de8cdb6e1a
commit 30fcef3892
10 changed files with 25 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/skills/python-code-reviewer/skill.md
+6 -4
View File
@@ -30,6 +30,7 @@ Perform thorough, evidence-based code reviews for Python projects. Every finding
3. **Verify Claims:** Run or reference project tooling (`ruff check`, `ty`, `pytest`) rather than guessing.
4. **Prioritize Hot Paths:** Focus deeply on request handling, database sessions, background workers, and external API calls.
5. **Enforce Read-Only Safety:** Do not modify code unless explicitly instructed.
6. **Escalate Provenance Audits:** For evidence/provenance-heavy changes, apply invariant checks from `.github/skills/evidence-provenance-auditor/skill.md` and include pass/fail outcomes in the report.
## Repo-Specific Deterministic Checks (Transcription)
@@ -39,10 +40,11 @@ When reviewing this repository, always include explicit pass/fail checks for:
2. **UI boundary rule:** pages/components do not perform persistence access (`tests/test_ui_boundaries.py`).
3. **Status vocabulary conformance:** `JobStatus`/`JobSourceStatus` usage matches current enums in `src/transcription/db/models.py`.
4. **Evidence ownership conformance:** append-only attempt history is preserved and projection writes are not mistaken for history mutation (`src/transcription/services/sources.py`, `src/transcription/services/evidence.py`).
5. **Canonical V4 authority:** findings must resolve against `docs/ver4/*` first, and treat `docs/ver4/history.md` plus `docs-v4x-archive` as historical context.
6. **Media boundary conformance:** print/export media is record-validated and UI media URL generation uses controlled resolver paths.
7. **Eager-loading conformance:** service/UI read paths satisfy `lazy="raise"` expectations.
8. **Cross-cutting error conformance:** service/API/UI translation and retry behavior align with `.github/instructions/error-handling.instructions.md`.
5. **Canonical V4 authority:** findings must resolve against `docs/ver4/*` first.
6. **Schema contract fidelity:** when model/persistence behavior changes, `docs/ver4/schema_v4.md` remains field-accurate with `src/transcription/db/models.py`.
7. **Media boundary conformance:** print/export media is record-validated and UI media URL generation uses controlled resolver paths.
8. **Eager-loading conformance:** service/UI read paths satisfy `lazy="raise"` expectations.
9. **Cross-cutting error conformance:** service/API/UI translation and retry behavior align with `.github/instructions/error-handling.instructions.md`.
## Core Review Areas